-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Create lib.rs
, to allow documentation tests to be written…
#153
Conversation
Adding this, as I'd like to start trying to add more docs/doc-tests for the code changes in ISSUE-16 |
This change seems to make much of the internals of cargo-geiger public through the |
837f678
to
2a7d2bb
Compare
Apologies @anderejd, this is a misunderstanding on my end, I hadn't realised a |
You can just slap a warning on it that the API provided by the In the meantime people may be interested in experimented with consuming |
@tarcieri's suggestion seems reasonable to me, @jmcconnell26 would you like to use that approach? |
2a7d2bb
to
8786f49
Compare
LGTM. I also think we should add the same or a similar disclaimer somewhere in the README.md. |
@anderejd, that sounds like a good idea to me! I'll add a section to the Apologies for the deluge of PRs B.T.W! |
8786f49
to
49c098a
Compare
Sure, the README.md is getting a bit long. This will deny users to read the changelog on creates.io though. A link to the changelog from the README.md could be nice, if that works on crates.io (?). |
Keep 'em coming 🚀 |
… and run: * Add high level description of public modules in `lib.rs` * Add docs and doc-tests for args module * Add clippy level to enforce use of doc markdown * Add disclaimer that lib is not stable * Update README to include disclaimer * Pull changelog to its own file * Add link to new CHANGELOG.md file to expose the change log on crates.io Signed-off-by: joshmc <[email protected]>
That's a good shout, I've updated the README.md to add a link to the new file. Thanks, |
49c098a
to
1390f8e
Compare
Looks great, thanks! Let's do this. |
… and
run:
lib.rs
Signed-off-by: joshmc [email protected]